Bring back account closing #3601
Conversation
|
Alright, so we no longer have bank withdrawals as a disbursement option. Do we try to add PayPal, which would require finding a one-off API, or do we simply remove bank withdrawal and leave it at that? |
|
I think we just remove bank withdrawal for now. We don't have a lot of time. |
|
The "final gift" disbursement strategy doesn't really make sense anymore since we're moving away from indefinite escrow (#1383). Once we start charging in arrears (#3378), and not holding funds to cover next week's payments (#3475), then the only reason to have money in escrow will be pending or failed payouts. |
|
And that means we no longer have disbursement strategies as part of account closing. |
|
I mean, unless we wanted to try to implement async PayPal payouts at some point. I don't think we need to care about that though, because we now require a payout route in order to receive money, and we're moving to a system in which the only way to have escrow is if your payout route has failed. I guess we should just make sure there are no pending payouts during account closing, since a pending payout could fail, and then what? |
|
Anyway, ripping out disbursement strategies entirely ... |
|
Alright, what's next? I guess we need to clear subscriptions instead of tips. And what about team ownership now? |
chadwhitacre
force-pushed
the
bring-back-closing
branch
from
afe4f37
to
d9b6725
Compare
Users no longer receive money directly, it all goes through teams first.
|
We have a couple options with teams: either we automatically close teams when the owner closes their account, or we make the owner go through a separate "close team" workflow first. We certainly want a "close team" workflow anyway. Do we want to make team owners jump through that hoop or otherwise confirm somehow that closing their account will close their team(s)? Probably. |
|
Do we release team slugs/names immediately upon team closing? |
|
Ooooh, that's right ... we don't have any team membership, only owners. :-( |
|
Ready for review, @rohitpaulk @rorepo et al. |
|
Gonna go ahead and self-merge, as this has been out for 10 days and we need to start landing some 2.0 cleanup so we can stay on track for August 20. |
Bring back account closing
|
General question, is it supposed to work live on the site once you merge? Or is there another step? I'm not hip on how git works. |
|
@mattbk - There is a deploy step after the merge. All deploys are logged in https://botbot.me/freenode/gratipay/, you could compare the timestamps to see if a merged PR has actually been deployed :) |
|
Thanks! On July 16, 2015 12:42:02 PM CDT, Paul Kuruvilla notifications@github.com wrote:
Sent from a phone that, although intelligent, is not street smart. |
Closes #3461.