This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
#3924 remove inapplicable badges; adjust title #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The xfailed are expected. Some of the other failures are going to be due to dependencies I introduced underneath #4148 (@kaguillera is seeing similar on #4128). Sorry—I will work on that. Not sure whether that'll be all of them, though. |
This was referenced Nov 4, 2016
|
Please review. It passes test now. |
|
!m @nobodxbodon |
|
Deployed! Thanks for the PR, @nobodxbodon! 💃 🌻
|
This was referenced Nov 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed there are many test failures:
5 failed, 677 passed, 36 xfailed, 17 error
Is there something wrong with my local settings? Or they are just broken?