This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Harmonize package deletion and claiming #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move upsert & delete onto Package - Make verification results easier to debug - Smooth out a slight very wrinkle in return value for paypal_updated - Implement and test desired behavior
25 tasks
|
Ready for review, @dowski @rohitpaulk! :) |
|
Bump! I am ready to bring #4305 in for a landing! |
clone1018
approved these changes
May 9, 2017
| cursor = cursor or self.db | ||
| if self.load_team(cursor): | ||
| self.unlink_team(cursor) | ||
| cursor.run("DELETE FROM claims WHERE package_id=%s", (self.id,)) |
There was a problem hiding this comment.
Is the comma at the end of (self.id,) expected?
There was a problem hiding this comment.
Yes, it's a Python wart. We want this to be a tuple, but without the comma it is just a parenthetical expression.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for #4305 now that #4438 is in.