Change versioning logic #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflect the fact that the latest major Teleport release is not available to Teleport Enterprise Cloud customers until a few weeks after the release date. Configure versioning for v17. Use an `isDefault` key in `config.json` to specify the default version. This way, we can specify the default version explicitly using config.json instead of using the potentially confusing `current` and `latest` fields. Configure git modules. Remove 14.x and add 18.x. Remove the "normalize" function, which is dead code. Remove the latest version suggestion link from the version banner. It's not always accurate (e.g., if we have different versions for Cloud and Self-Hosted), and users can find the dropdown anyway. Adjust the version banner text if a docs version is only available for self-hosted Teleport clusters.
|
Preview details
|
taraspos
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect the fact that the latest major Teleport release is not available to Teleport Enterprise Cloud customers until a few weeks after the release date. Configure versioning for v17.
Use an
isDefaultkey inconfig.jsonto specify the default version. This way, we can specify the default version explicitly using config.json instead of using the potentially confusingcurrentandlatestfields.Configure git modules. Remove 14.x and add 18.x.
Remove the "normalize" function, which is dead code.
Remove the latest version suggestion link from the version banner. It's not always accurate (e.g., if we have different versions for Cloud and Self-Hosted), and users can find the dropdown anyway.
Adjust the version banner text if a docs version is only available for self-hosted Teleport clusters.