This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
[7.0] set 100000 fds on systemd unit creation if unspecified (#2315) #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set unlimited fds on systemd unit creaiton if unspecified * use a large cap instead of relying on infinite behaviour * fix typo * address review feedback (cherry picked from commit 4510a5d)
knisbet
changed the title
lenko-d
approved these changes
Nov 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some distros / versions of systemd default to 1024 open fds. So by default if unspecified, create systemd units from gravity with 100000 fds as 1024 is far too low for gravity daemons by default.
Type of change
Linked tickets and other PRs
Updates #2314
Ports #2315
TODOs
Implementation
I just set this to infinity if not specified, to avoid any defaults / limits.
Performance/Scaling
I suppose in theory this could cause issues with lots of open connections that will present in a different way than being blocked due to max open fds.
Testing done
Created an equivelant change and tested it on a test cluster. New Unit tests. Relying on robotest for this.
Additional information
(cherry picked from commit 4510a5d)