This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Add TODO item for upstream pending PRs to template #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knisbet
requested review from
wadells,
eldios,
lenko-d,
UnderGreen,
bernardjkim,
ulysseskan and
a team
UnderGreen
approved these changes
Nov 19, 2020
wadells
approved these changes
Nov 19, 2020
lenko-d
approved these changes
Nov 19, 2020
bernardjkim
approved these changes
Nov 19, 2020
ulysseskan
approved these changes
Nov 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a bit of confusion lately with the team practices that we tend to approve changes before the PR is totally complete, and will accept the changes expecting an update before merge. For the project I think this is a needed practice, but I think @wadells does a great job of communicating this intention as a checklist item as in #2335.
So if the team is onboard, let's add a checklist item for it when required, to more clearly communicate when there are small changes to the upstream references needed ahead of merge.
Thoughts?