This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
[7.0] fallback installed etcd version on corrupt metadata #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use alternate method for detecting running etcd version when loading corrupted planet metadata using custom planet containers. This change allows the fallthrough to the alternate behaviour of detecting running etcd version, when reading the corrupted metadata.
Tested against the scenario customer S is running into.
Type of change
Linked tickets and other PRs
Updates #2031
Ports #2032
TODOs
Implementation
This is really a workaround for a specific bug that shipped in several versions of 6.1, has been fixed in 6.1, but prevents a direct upgrade path from those versions of 6.1 to 7.0.
Testing done
Built an app on 6.1.22 with custom planet, and built an upgrade on this PR branch with normal planet (specific situation customer S is in). Upgrade completes without issue.
Additional information