Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

[7.0.x] Add Helm 3 binary #2345

Merged
merged 4 commits into from
Nov 26, 2020
Merged

[7.0.x] Add Helm 3 binary #2345

merged 4 commits into from
Nov 26, 2020

Conversation

UnderGreen
Copy link
Contributor

Description

Add Helm 3 binary on host.

Type of change

  • New feature (non-breaking change which adds functionality)

Linked tickets and other PRs

TODOs

  • Self-review the change
  • Perform manual testing
  • Address review feedback
  • Update upstream references / tags / versions after upstream PR merges (linked above)

Implementation

Performance/Scaling

Testing done

Additional information

Sergei Antipov added 2 commits November 21, 2020 11:23
* Create symlink on host for Helm 3

* Fix variable

* Set helm 3 binary path on host

* Bump planet tag
@UnderGreen UnderGreen requested review from a team, wadells and lenko-d November 23, 2020 11:25
Copy link
Contributor

@wadells wadells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks reasonable.

Where do you discuss your testing? I see the box ticked, but I don't see any discussion of what you tested in this PR, #2303 or the corresponding planet PRs.

@UnderGreen
Copy link
Contributor Author

For here test was just about the existence of helm 3 binaries on the host and inside planet. I didn't test it functionality this time but for #2303 it was done by testing simple hart installation

@UnderGreen UnderGreen merged commit 22403f8 into version/7.0.x Nov 26, 2020
@UnderGreen UnderGreen deleted the sergei/70x/helm3_binary branch November 26, 2020 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants