This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
add temporary failures as a reason to retry kubernetes failures #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry-transient-errors
bernardjkim
approved these changes
Sep 27, 2021
knisbet
pushed a commit
that referenced
this pull request
Sep 28, 2021
(cherry picked from commit 03d0169)
knisbet
pushed a commit
that referenced
this pull request
Sep 28, 2021
(cherry picked from commit 03d0169)
knisbet
pushed a commit
that referenced
this pull request
Sep 28, 2021
(cherry picked from commit 03d0169)
knisbet
pushed a commit
that referenced
this pull request
Sep 28, 2021
(cherry picked from commit 03d0169)
knisbet
pushed a commit
that referenced
this pull request
Sep 28, 2021
knisbet
pushed a commit
that referenced
this pull request
Sep 28, 2021
knisbet
pushed a commit
that referenced
this pull request
Sep 28, 2021
knisbet
pushed a commit
that referenced
this pull request
Sep 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing retries on transient errors in kubernetes operations.
Type of change
Linked tickets and other PRs
Updates #2650
TODOs
Implementation
This is a relatively small and self contained change, as reported by Customer S, they see a higher than expected failure rate in their CI of upgrade testing. We got a stack trace from them (excerpt in #2650) that show's we're not retrying on "connection refused" errors.
I didn't do any manual testing on this one, as it would likely be a bit tricky to produce the right network error at the correct time. That also would only cover the specific error, where it looks like lots of temporary failures are missing in the logic. Worst case is we retry a few times for something we shouldn't.
The "connect refused" error as present in the stack, should be covered by the existing utils.IsTransientClusterError, and I threw in various kubernetes transient errors as good measure. https://github.com/gravitational/gravity/blob/master/lib/utils/error.go#L106-L132
Testing done
Only looking for robotest results. See justification above.
Additional information