This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
[6.1.x] Add pod-subnet-size flag #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
lenko-d
approved these changes
Nov 5, 2020
a-palchikov
approved these changes
Nov 5, 2020
tool/planet/cfg.go
Outdated
| @@ -79,6 +79,8 @@ type Config struct { | |||
| ServiceCIDR kv.CIDR | |||
| // PodCIDR defines the kubernetes Pod subnet CIDR | |||
| PodCIDR kv.CIDR | |||
There was a problem hiding this comment.
nit: Somewhat unrelated but I faced the same issue with kv.CIDR and introduced a local flag that would expose the net.IPNet so you don't need to reparse it: https://github.com/gravitational/planet/blob/bernard/6.1.x/subnet-size/tool/planet/args.go#L28. This could save a couple of lines in verifyPodSubnetSize.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
--pod-subnet-sizeflag to determine the size of the subnet allocated to each host. The default size is /24, the max value is /28, and it cannot be larger than the pod CIDR range itself. The pod subnet size can also be specified and read from thePLANET_POD_SUBNET_SIZEenvironment variable.Linked tickets and PRs