Update go modules to address dependency CVE #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentfoo
approved these changes
Oct 20, 2023
reedloden
approved these changes
Oct 20, 2023
|
We should add this project to the Dependabot config as well: https://github.com/gravitational/shared-workflows/blob/main/.github/dependabot.yml |
That's for automated version updates, no? I thought security updates were separate. |
|
@reedloden Sorta. If you have no Dependabot configuration at all you get CVE only updates. But I believe once you create a Dependabot configuration it will only scan projects which are defined in that config. If we still only want CVE updates we need to set the |
jentfoo
added a commit
that referenced
this pull request
Oct 20, 2023
I believe this is why the flagged updates in PR #172 were missed.
jentfoo
added a commit
that referenced
this pull request
Oct 23, 2023
I believe this is why the flagged updates in PR #172 were missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Orca tool is reporting a 7.5 CVE in the Golang yaml dependency. Most of the dependencies are a little out of date so I've gone ahead and bumped them all.
We don't have any tests for the bot, but it still compiles ¯\(ツ)/¯