Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env-loader: bug fixes #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

env-loader: bug fixes #295

wants to merge 1 commit into from

Conversation

fheinecke
Copy link
Contributor

Fixed the following bugs with the env loader tool:

  • environments-directory arg shared an environment variable with the environments arg
  • No output would be produced if no values were specifically requested, instead of outputting all loaded values
  • Git repo root not properly detected when the repo is a submodule
  • Environment names with a / character in them would search individual components instead of the full path (i.e. .environments/stage and .environments/build instead of .environments/stage/build)

@fheinecke fheinecke requested a review from a team as a code owner November 19, 2024 20:16
@zmb3
Copy link
Contributor

zmb3 commented Nov 19, 2024

Is it possible to write some tests to lock in this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fheinecke @zmb3