Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change navigation based on the scope #14052

Closed
klizhentas opened this issue Jul 1, 2022 · 0 comments · Fixed by #14085
Closed

Do not change navigation based on the scope #14052

klizhentas opened this issue Jul 1, 2022 · 0 comments · Fixed by #14085
Assignees

Comments

@klizhentas
Copy link
Contributor

klizhentas commented Jul 1, 2022

Navigation should not change based on the scope, because people can't find relevant sections if they are in the wrong scope. Let's fix this until we find a better solution. Example, it's impossible to know what's missing in the enterprise section if you are in the wrong scope, what hurts discoverability and creates confusion:

Screen Shot 2022-07-01 at 11 07 07 AM

Vs enterprise scope:

Screen Shot 2022-07-01 at 11 06 56 AM

This creates issues with google indexing as well:

image (2)

We should not use:

hideInScopes feature for that reason.

Instead, our navigation should be static (similar to Gitlab) and we should use the solution I described here:

gravitational/docs#85

We should also remove the in-page scope switcher that does not work in many browsers today: (e.g. Brave does not redirect)

Screen Shot 2022-07-03 at 4 45 00 PM

klizhentas added a commit that referenced this issue Jul 5, 2022
remove blocks hiding content and scope links, fixes #14052
ptgott pushed a commit that referenced this issue Jul 5, 2022
Backports #14085

remove blocks hiding content and scope links, fixes #14052
ptgott pushed a commit that referenced this issue Jul 5, 2022
Backports #14085

remove blocks hiding content and scope links, fixes #14052
ptgott pushed a commit that referenced this issue Jul 5, 2022
Backports #14085

remove blocks hiding content and scope links, fixes #14052
ptgott pushed a commit that referenced this issue Jul 6, 2022
Backports #14085

remove blocks hiding content and scope links, fixes #14052
ptgott pushed a commit that referenced this issue Jul 6, 2022
Backports #14085

remove blocks hiding content and scope links, fixes #14052
ptgott pushed a commit that referenced this issue Jul 6, 2022
Backports #14085

remove blocks hiding content and scope links, fixes #14052
ptgott added a commit that referenced this issue Jul 6, 2022
docs: remove blocks hiding content and scope links

Backports #14085

remove blocks hiding content and scope links, fixes #14052

Co-authored-by: Alexander Klizhentas <klizhentas@gmail.com>
ptgott added a commit that referenced this issue Jul 6, 2022
docs: remove blocks hiding content and scope links

Backports #14085

remove blocks hiding content and scope links, fixes #14052

Co-authored-by: Alexander Klizhentas <klizhentas@gmail.com>
ptgott added a commit that referenced this issue Jul 6, 2022
docs: remove blocks hiding content and scope links

Backports #14085

remove blocks hiding content and scope links, fixes #14052

Co-authored-by: Alexander Klizhentas <klizhentas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants