TestAllowedUsers flakiness

[GavinFrazar]

Failure

Link(s) to logs

• https://console.cloud.google.com/cloud-build/builds/0b892cd7-61cd-4a01-94e3-d90e771adfc7?project=ci-account

Relevant snippet

FAIL: github.com/gravitational/teleport/lib/srv/regular
FAIL: github.com/gravitational/teleport/lib/srv/regular.TestAllowedUsers
===================================================
OUTPUT github.com/gravitational/teleport/lib/srv/regular.TestAllowedUsers
===================================================
=== RUN   TestAllowedUsers
=== PAUSE TestAllowedUsers
=== CONT  TestAllowedUsers
=== CONT  TestAllowedUsers
    sshserver_test.go:225: 
        	Error Trace:	sshserver_test.go:225
        	            				sshserver_test.go:111
        	            				sshserver_test.go:886
        	Error:      	Received unexpected error:
        	            	timeout waiting for announce to be sent

[GavinFrazar]

Reran locally and test passed. My PR only made changes to config file parsing/tests in completely unrelated code.

[GavinFrazar]

@tcsc Whoops, read the blame wrong you merely moved some code around. I think the relevant git blame is actually from 9b22af6 so I'll reassign

[zmb3]

@rosstimothy this is back on v15: https://github.com/gravitational/teleport/actions/runs/7631628626/job/20790004582

=== FAIL: lib/srv/regular TestAllowedUsers (9.45s)
{"caller":"backend/buffer.go:283","component":"buffer","level":"debug","message":"Removing watcher headless_authentication (0xc002434000) via external close.","timestamp":"2024-01-23T20:52:42Z"}
    sshserver_test.go:257: 
        	Error Trace:	/__w/teleport/teleport/lib/srv/regular/sshserver_test.go:257
        	            				/__w/teleport/teleport/lib/srv/regular/sshserver_test.go:127
        	            				/__w/teleport/teleport/lib/srv/regular/sshserver_test.go:1148
        	Error:      	Received unexpected error:
        	            	timeout waiting for announce to be sent
        	Test:       	TestAllowedUsers

[rosstimothy]

We also see timeout waiting for announce to be sent from just about every test in lib/srv every few days from the nightly test reporter.

[rosstimothy]

Fixed by #38076