Attempts to stabilize lib/srv/regular tests #38076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests that use the common fixture suffer from periodic failures due to `timeout waiting for announce to be sent`. This stems from the fixture forcing a heartbeat for the node being created in the test timing out. Instead of using the heartbeat interface to fire an early heartbeat, the server is upserted directly into the test auth instance.
rosstimothy
added
the
no-changelog
zmb3
approved these changes
Feb 11, 2024
AntonAM
approved these changes
Feb 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
|
@rosstimothy See the table below for backport results.
|
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests that use the common fixture suffer from periodic failures due to
timeout waiting for announce to be sent. This stems from the fixture forcing a heartbeat for the node being created in the test timing out. Instead of using the heartbeat interface to fire an early heartbeat, the server is upserted directly into the test auth instance.