Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestWebAgentForward flakiness #17918

Closed
nklaassen opened this issue Oct 28, 2022 · 1 comment · Fixed by #19580
Closed

TestWebAgentForward flakiness #17918

nklaassen opened this issue Oct 28, 2022 · 1 comment · Fixed by #19580
Labels
flaky tests

Comments

@nklaassen
Copy link
Contributor

Failure

Link(s) to logs

Relevant snippet

    testing.go:1097: TempDir RemoveAll cleanup: unlinkat /tmp/TestWebAgentForward2505968907/002/log/upload/streaming/default/multi/e831e256-d73a-442a-aec1-d3fe4fd9b47d/6f55c068-6459-41df-a401-bda7822f6b82: directory not empty
--- FAIL: TestWebAgentForward (7.56s)
@nklaassen nklaassen mentioned this issue Oct 28, 2022
Closed
@zmb3
Copy link
Collaborator

zmb3 commented Dec 21, 2022

I can't reproduce the original failure, though it would be easy to eliminate by disabling async recording.

Also note that this test also suffers from the issue described in #13335.

zmb3 added a commit that referenced this issue Dec 21, 2022
@zmb3
Disable disk-based recording for TestWebAgentForward
b734b6b 
Also improve the correctness of web tests that use waitForOutput
by checking if the output was received even when the read fails
with an error.

Fixes #17918
@zmb3 zmb3 mentioned this issue Dec 21, 2022
Merged
zmb3 added a commit that referenced this issue Dec 22, 2022
@zmb3
Disable disk-based recording for TestWebAgentForward (#19580)
749dbcd 
Also improve the correctness of web tests that use waitForOutput
by checking if the output was received even when the read fails
with an error.

Fixes #17918
github-actions bot pushed a commit that referenced this issue Dec 22, 2022
@zmb3
Disable disk-based recording for TestWebAgentForward
1e3cf49 
Also improve the correctness of web tests that use waitForOutput
by checking if the output was received even when the read fails
with an error.

Fixes #17918
zmb3 added a commit that referenced this issue Dec 28, 2022
@zmb3
Disable disk-based recording for TestWebAgentForward (#19630)
14fc116 
Also improve the correctness of web tests that use waitForOutput
by checking if the output was received even when the read fails
with an error.

Fixes #17918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable disk-based recording for TestWebAgentForward gravitational/teleport
2 participants
@zmb3 @nklaassen