-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: tsh login
should support --bind
parameter
#2620
Comments
Love it. Two considerations:
.. should work. |
@kontsevoy thanks for your vote! Your considerations make sense to me. |
One more feature request related to this: support e.g.
|
@klizhentas any updates on this? We are blocked on this for one of our Teleport Enterprise customers and will soon have this with another Enterprise customer =) |
@osterman understood. We will roll this for 3.2.x patch early next week. |
working on this right now |
Thanks for the update @klizhentas |
Working versions:
|
This commit adds `--bind-addr` flag to tsh login and TELEPORT_LOGIN_BIND_ADDR environment variable to set up login bind address for SSO redirect flows. Usage examples: ``` tsh login --bind-addr=localhost:3333 tsh login --bind-addr=:3333 tsh login --bind-addr=[::1]:3333 TELEPORT_LOGIN_BIND_ADDR=localhost:7777 tsh login ```
Beautiful!! @Nuru can you give this a go? |
This commit adds `--bind-addr` flag to tsh login and TELEPORT_LOGIN_BIND_ADDR environment variable to set up login bind address for SSO redirect flows. Usage examples: ``` tsh login --bind-addr=localhost:3333 tsh login --bind-addr=:3333 tsh login --bind-addr=[::1]:3333 TELEPORT_LOGIN_BIND_ADDR=localhost:7777 tsh login ```
Not a complete solution, @osterman. See #2646 (comment) |
This commit adds `--bind-addr` flag to tsh login and TELEPORT_LOGIN_BIND_ADDR environment variable to set up login bind address for SSO redirect flows. Usage examples: ``` tsh login --bind-addr=localhost:3333 tsh login --bind-addr=:3333 tsh login --bind-addr=[::1]:3333 TELEPORT_LOGIN_BIND_ADDR=localhost:7777 tsh login ``` Refactor redirect flow and fix URLs for --bind-addr
@klizhentas we got everything working in |
What happened:
Running
tsh login
inside of a docker container on "Docker for Mac" opens a server on a random port that we cannot access. We cannot use--net=host
on "Docker for Mac", so we need a way to explicitly port map a port to the container.What you expected to happen:
We expected
tsh login
support an argument to specify an explicit port.For example, we use
kubectl proxy
inside of the same container. Withkubectl proxy
, we do the following:With
tsh login
, we would expect to be able to do something similar:Which would permit us to do something like this when we start up our container:
The text was updated successfully, but these errors were encountered: