Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level on "Conflict on event session_id and event_index error" for DynamoDB events #46801

Open
greedy52 opened this issue Sep 20, 2024 · 0 comments
Assignees
Labels
bug c-bp Customer Internal Reference c-gr Internal Customer Reference support-load This issue generates support load

Comments

@greedy52
Copy link
Contributor

greedy52 commented Sep 20, 2024

Background:
#40854 adds a fallback to fix index 0 conflict for the DynamoDB events. We kept the error level log for the original conflict error even though the fallback could be successful afterwards, so we could capture which events might still send the conflict index. However, many customers monitor Teleport's log and these errors give false positives.

Expected behavior:

  • (optional) We should fix the origins that still send conflicting indexes to avoid the fallback, if possible
  • If the fallback is successful, the original error must not generate an error log

Current behavior:
The following error is spamming despite followed by a successful overwrite:

2024-09-19T05:43:06Z ERRO [DYNAMODB]  Conflict on event session_id and event_index error:[
ERROR REPORT:
Original Error: *trace.AlreadyExistsError ConditionalCheckFailedException: The conditional request failed
{
  RespMetadata: {
    StatusCode: 400,
    RequestID: "3V6F4JBK7AD6ELMLI2QO1F0LK3VV4KQNSO5AEMVJF66Q9ASUAAJG"
  },
  Message_: "The conditional request failed"
}
Stack Trace:
    github.com/gravitational/teleport/lib/events/dynamoevents/dynamoevents.go:1089 github.com/gravitational/teleport/lib/events/dynamoevents.convertError
    github.com/gravitational/teleport/lib/events/dynamoevents/dynamoevents.go:455 github.com/gravitational/teleport/lib/events/dynamoevents.(*Log).putAuditEvent
    github.com/gravitational/teleport/lib/events/dynamoevents/dynamoevents.go:376 github.com/gravitational/teleport/lib/events/dynamoevents.(*Log).EmitAuditEvent

(zendesk ticket 11706)

Bug details:

  • Teleport version: v16
  • Recreation steps: DynamoDB events + session.command
@greedy52 greedy52 added bug support-load This issue generates support load labels Sep 20, 2024
@programmerq programmerq added the c-gr Internal Customer Reference label Sep 20, 2024
@programmerq programmerq added the c-bp Customer Internal Reference label Oct 18, 2024
rosstimothy added a commit that referenced this issue Nov 6, 2024
Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Closes #46801
rosstimothy added a commit that referenced this issue Nov 6, 2024
Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
rosstimothy added a commit that referenced this issue Nov 7, 2024
Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
…48548)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
github-actions bot pushed a commit that referenced this issue Nov 7, 2024
Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
rosstimothy added a commit that referenced this issue Nov 7, 2024
…48548)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
rosstimothy added a commit that referenced this issue Nov 7, 2024
…48548)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
…48605)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
…48548) (#48624)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
…48548) (#48626)

Alters the log messages from #40854
such that they only occur if the fallback mechanism fails.

Updates #46801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c-bp Customer Internal Reference c-gr Internal Customer Reference support-load This issue generates support load
Projects
None yet
Development

No branches or pull requests

3 participants