Change web get resources api response #10598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
changed the title
kimlisa
force-pushed
the
lisa/change-api-response
branch
from
b4e381d to
ca46af9
Compare
rosstimothy
approved these changes
Feb 25, 2022
espadolini
requested changes
Feb 25, 2022
kimlisa
force-pushed
the
lisa/change-api-response
branch
from
0137417 to
ca46af9
Compare
kimlisa
force-pushed
the
lisa/change-api-response
branch
from
ca46af9 to
051da5e
Compare
espadolini
approved these changes
Feb 25, 2022
@espadolini handling backwards compatibility for webassets has been very fuzzy to me. Backwards compat becomes a problem where there are mixed proxy versions: one older version can serve the old webassets, and an api call can go to a newer proxy returning a new response (and vice versa). I'm not sure how realistic it is for proxy versions to be mixed for long though, so with this assumption I did not supply fallbacks |
zmb3
approved these changes
Feb 28, 2022
kimlisa
added a commit
that referenced
this pull request
Feb 28, 2022
* Created a general listResourcesGetResponse as a consistent return value * Wrapped response in ^ object for resources that were not wrapped to accommodate future changes (dbs, desktops, kubes)
kimlisa
added a commit
that referenced
this pull request
Mar 1, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of RFD 55
Description
listResourcesGetResponseas a consistent return value