-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit four docs guides for Cloud users #10738
Conversation
87e8cd6
to
47f6d4a
Compare
47f6d4a
to
5156b35
Compare
directory. Assuming the default location, `rm -rf /var/lib/teleport/*` will do. | ||
Sometimes you may want to reset the `teleport` process to a clean state. This | ||
can be accomplished by erasing everything under the `"data_dir"` directory. | ||
Assuming the default location, `rm -rf /var/lib/teleport/*` will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this rm -rfi /var/lib/teleport/*
just in case someone is typing this manually and absentmindedly types rm -rf /var/lib
by mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed each of the files changed and they all look good to me. I made one minor safety suggestion above but it's up to you if you want to make that change.
002ef9a
to
5dd867e
Compare
34c4ae5
to
7ae6453
Compare
01c9a74
to
b0b596b
Compare
8d2eb8b
to
d40a8d9
Compare
|
||
## Prerequisites | ||
|
||
(!docs/pages/includes/edition-prereqs-tabs.mdx!) | ||
|
||
(!docs/pages/includes/tctl.mdx!) | ||
|
||
## Labeling Nodes and Applications | ||
## Labeling nodes and applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I thought we were capitalizing Node
- Why mention nodes and apps here, given the title is just "how to label Teleport Nodes" and there are many other resources that also can be labeled (kube clusters, dbs, desktops, etc) What's special about applications that they get to be included here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it was before I started editing the guide, and a full update was out of scope for that particular sprint. I've replaced "Nodes and applications" with variations on "Teleport resources".
See #10633 Labels - Turn the Prerequisites into a Tabs box for different editions. This means that users of one edition will not need to see information intended for users of another edition. - Add misc. clarity, grammar, and style edits. Local Users - Use Tabs for the Prerequisites so users of one edition don't see information for another edition - SSO was briefly mentioned without elaboration, so I added this to a Further Reading section with scoped tabs - Use Tabs for Proxy connection instructions Troubleshooting - Add a note re: the relevance of the guide for Cloud users - Add Tabs for the Getting help section so commercial or OSS users don't see irrelevant information - General clarity, grammar, and style tweaks Graceful Restarts - Add a notice indicating how this guide is relevant for Cloud users - Misc clarity, grammar, and style tweaks
d40a8d9
to
dc4d3ef
Compare
See #10633
Labels
Turn the Prerequisites into a Tabs box for different editions.
This means that users of one edition will not need to see
information intended for users of another edition.
Add misc. clarity, grammar, and style edits.
Local Users
information for another edition
Further Reading section with scoped tabs
Troubleshooting
don't see irrelevant information
Graceful Restarts