Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add desktop session recording and clipboard sharing #11005

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Mar 9, 2022

Note to reviewers: I figured I would start getting a review on the content before I added screenshots. I'll be sure to add them before this is merged.

Backports required:

  • branch/v9

}

- what if unsupported browser
- what if user clicks no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- what if user clicks no
If you mistakenly deny clipboard permissions when prompted, you can change the setting by clicking the lock on the left side of your address bar, selecting the correct permission, and then refreshing the page

Screen Shot 2022-03-10 at 10 08 26

Click the play button to open the player in a new tab. The desktop session
player supports toggling between play and pause, but does not support seeking to
a specific point in the stream, rewinding, or restarting playback when the end
of the stream is reached.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of the stream is reached.
of the stream is reached. To replay a session, simply refresh the page.

},
{
"title": "Reference",
"slug": "/desktop-access/reference/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link 404s. I think we should either add a reference.mdx page with a tile for each child page or use the slug for one of the child pages instead.

Teleport Desktop Access supports copying and pasting text between your browser
and a remote Windows Desktop.

<Adminition type="note">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Adminition type="note">
<Admonition type="note">

/* screenshot of recordings table */
}

<Adminition type="note" title="RBAC for sessions">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Adminition type="note" title="RBAC for sessions">
<Admonition type="note" title="RBAC for sessions">

title: Session Recording and Playback
description: Recording and Playing Back Teleport Desktop Access Sessions.
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a separate H1 section on disabling session recording?

If so, we'd need to move the first sentence of this next paragraph before the H1 header.

@zmb3 zmb3 force-pushed the zmb3/docs-desktop-clipboard-sessions branch from 9074875 to ebdc3a7 Compare March 14, 2022 21:06
@zmb3
Copy link
Collaborator Author

zmb3 commented Mar 14, 2022

@ibeckermayer @ptgott please take a look at the latest revision - I think I've addressed everything.

@zmb3 zmb3 force-pushed the zmb3/docs-desktop-clipboard-sessions branch from e701256 to 806c91a Compare March 15, 2022 00:04
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a tiny suggestion

Share your clipboard with a remote desktop.
</Tile>
<Tile icon="play" title="Session Recording" href="./reference/sessions.mdx">
Desktop session recording and playback
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Desktop session recording and playback
Desktop session recording and playback.

for consistency

@zmb3 zmb3 enabled auto-merge (squash) March 16, 2022 15:41
@zmb3 zmb3 disabled auto-merge March 16, 2022 15:50
@zmb3 zmb3 enabled auto-merge (squash) March 16, 2022 22:30
@zmb3 zmb3 merged commit 9c749e8 into master Mar 16, 2022
@zmb3 zmb3 deleted the zmb3/docs-desktop-clipboard-sessions branch March 16, 2022 22:35
@zmb3 zmb3 mentioned this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants