fix panic child.Close() called without logger initialized #11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
commented
Mar 14, 2022
| @@ -369,6 +369,9 @@ func NewServerContext(ctx context.Context, parent *sshutils.ConnectionContext, s | |||
| cancel: cancel, | |||
| } | |||
|
|
|||
| // Pre-setup log entry in case early failures need to log something. | |||
| child.initLogEntry() | |||
|
|
|||
| authPref, err := srv.GetAccessPoint().GetAuthPreference(ctx) | |||
| if err != nil { | |||
| childErr := child.Close() | |||
There was a problem hiding this comment.
child.Close() calls reportStats which wants to log a message.
Line 809 in 823fc29
codingllama
reviewed
Mar 14, 2022
greedy52
force-pushed
the
STeve/fix_a_panic_srv_ctx_close
branch
from
ebac4aa to
b39f105
Compare
zmb3
approved these changes
Mar 14, 2022
codingllama
approved these changes
Mar 14, 2022
greedy52
added a commit
that referenced
this pull request
Jun 27, 2022
greedy52
added a commit
that referenced
this pull request
Jun 27, 2022
greedy52
added a commit
that referenced
this pull request
Jun 27, 2022
greedy52
added a commit
that referenced
this pull request
Jun 27, 2022
greedy52
added a commit
that referenced
this pull request
Jun 27, 2022
greedy52
added a commit
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run into a CI failure where a panic happens when
ServerContexttries to log an error message inreportStatsbut logger is not initialized yet.Not sure what's the root cause that run into this. At the minimum should fix the crash.