-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't enforce standard k8s and ssh auth mechanisms when joining sessions #11144
Conversation
ee78096
to
671d7d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me other than the minor suggestions here, but I am not super familiar with this code.
@xacrimon Can you add test coverage to this PR? |
@xacrimon Just checking, are we going to close this one and go with a different approach? |
e95ebdc
to
61683e6
Compare
8ccee72
to
c7d7b23
Compare
@r0mant Can you take another look at this PR please since you left a request-changes status last? |
23855ca
to
5136056
Compare
friendly ping: @r0mant |
We currently enforce standard SSH and K8S auth mechanisms to determine resource access in addition to the Moderated Sessions join check, we shouldn't do this since it prevents configuring the ability to join sessions without the ability to start them.
Notable changes:
session
service and the semi-hacky metadata keys.This is well covered by existing tests, relevant tests have been adjusted.