Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] revert #9540 (static role check for access request deletion) #11221

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

espadolini
Copy link
Contributor

@espadolini espadolini commented Mar 17, 2022

This PR reverts #9540. As #9540 was never backported at the time, it's only in master and v9. (see #11220)

The original intent behind #9540 was to mitigate the lack of visibility over access request deletions, as a malicious actor who was able to escalate permissions through access requests in such a way that they were also granted deletion permissions could acquire credentials and then delete the access requests used to hide their tracks.

After #9758 and #9552 this concern no longer exists, and (as @nklaassen found out) the way #9540 is implemented breaks tctl requests rm (because the system user used by tctl with the Admin role is not a user that exists in the backend), so the cleanest solution is to remove this special case altogether.

@espadolini espadolini merged commit 53f6e90 into branch/v9 Mar 17, 2022
@espadolini espadolini deleted the espadolini/v9-revert-access-request-deletion branch March 17, 2022 16:21
@webvictim webvictim mentioned this pull request Apr 19, 2022
@webvictim webvictim mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants