Always use in-memory caches #11386
Merged
Always use in-memory caches #11386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
force-pushed
the
espadolini/in-memory-cache
branch
from
b17692f to
37effb8
Compare
This was referenced Mar 23, 2022
espadolini
force-pushed
the
espadolini/in-memory-cache
branch
2 times, most recently
from
e2e0772 to
867ae4d
Compare
xacrimon
approved these changes
Mar 29, 2022
rosstimothy
approved these changes
Mar 30, 2022
This also cleans up now-useless fields and constants related to on-disk caches.
As we're never reopening the same cache backend twice, this is no longer useful.
espadolini
force-pushed
the
espadolini/in-memory-cache
branch
from
74a34c4 to
608fdc6
Compare
We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running.
espadolini
force-pushed
the
espadolini/in-memory-cache
branch
from
608fdc6 to
b923683
Compare
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running.
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running.
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running.
This was referenced Apr 1, 2022
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches (#11386) * Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running. * Default to synchronous FULL for sqlite (#11387)
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches (#11386) * Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running. * Default to synchronous FULL for sqlite (#11387)
espadolini
added a commit
that referenced
this pull request
Apr 1, 2022
* Always use in-memory caches (#11386) * Always use in-memory caches This also cleans up now-useless fields and constants related to on-disk caches. * Remove the cache tombstone mechanism As we're never reopening the same cache backend twice, this is no longer useful. * Warn if a cache directory exists on disk We can't remove it automatically because we might be in the middle of an upgrade with a old version of Teleport still running. * Default to synchronous FULL for sqlite (#11387)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #11022 without maintaining the ability to run caches with sqlite in temporary directories. The reason is unchanged.