[branch/v7] Respect Firestore commit write limits (#12111) #12175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestore only allows 500 writes per commit. Prior to this change DeleteRange or purgeExpiredDocuments could result in deleting more than 500 documents and would result in an error. To comply with the limits both DeletRange and purgeExpiredDocuments now call deleteDocuments which properly handles limiting a batch to 500 writes and commiting multiple times until all documents have been removed. Fixes #12007 (cherry picked from commit b543b99) # Conflicts: # lib/backend/firestore/firestorebk_test.go
smallinsky
approved these changes
Apr 22, 2022
Tener
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertobranch/v7:Questions ?
Please refer to the Backport tool documentation