[v9] Proxy restart fixes #12488
Merged
[v9] Proxy restart fixes #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adapts utils.IsUseOfClosedNetworkError to check for net.ErrClosed even inside trace.Aggregate errors, makes it so that we always return something that would pass errors.Is(err, net.ErrClosed) when returning from a (net.Listener).Accept(), and handles closed listeners within our various Serve() loops so that we don't hit spurious backoff waits while shutting down.
Tener
approved these changes
May 12, 2022
|
@r0mant friendly bump to the top of the notifications |
rosstimothy
approved these changes
May 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #11802 to branch/v9