Code

Refactor rdpdr client#12750

Code

Merged

ibeckermayer merged 151 commits intowindows-desktop-directory-sharinggravitational/teleport:windows-desktop-directory-sharingfrom isaiah/irp-mj-refactorgravitational/teleport:isaiah/irp-mj-refactorCopy head branch name to clipboardJun 25, 2022

+356-299

Commits

Commits on Mar 31, 2022

• Creates a general vchan Client that can read chunked messages. rdpdr and cliprdr::Client's have the vchan::Client as a field.

  

  Isaiah Becker-Mayer

  committed
  24c1a90

• Tidying up

  

  Isaiah Becker-Mayer

  committed
  41ac367

• Merge branch 'master' into isaiah/reuse-vchan-read

  

  Isaiah Becker-Mayer

  authored
  58cac52

• small fixes

  

  Isaiah Becker-Mayer

  committed
  fa3531f

• Merge branch 'master' into isaiah/reuse-vchan-read

  

  Isaiah Becker-Mayer

  authored
  ab4d66d

Commits on Apr 1, 2022

• fixes linting errors

  

  Isaiah Becker-Mayer

  committed
  aaa8369

• Merge branch 'master' into isaiah/reuse-vchan-read

  

  Isaiah Becker-Mayer

  authored
  54b7e3d

• Merge branch 'master' into isaiah/reuse-vchan-read

  

  Isaiah Becker-Mayer

  authored
  071620b

• Merge branch 'master' into isaiah/reuse-vchan-read

  

  Isaiah Becker-Mayer

  authored
  52a3d5d

• Adds drive redirection capability set to the Client Core Capability Response

  

  Isaiah Becker-Mayer

  committed
  ceddf84

Commits on Apr 4, 2022

• Adds the ClientDeviceListAnnounce message, plus some prototype code to trigger it by right-clicking, however it isn't working. One reason is that the vchannel PDU header isn't being added (see rdpd…

  Show description for 6baccf6
  

  Isaiah Becker-Mayer

  committed
  6baccf6

• Adds to_unicode util

  

  Isaiah Becker-Mayer

  committed
  9036618

• refactor of vchan and rdpdr to use it

  

  Isaiah Becker-Mayer

  committed
  770f6e7

• refactors cliprdr to use generalized vchan header and chunking

  

  Isaiah Becker-Mayer

  committed
  17a35e8

• nits

  

  Isaiah Becker-Mayer

  committed
  c946b52

• Merge branch 'master' into isaiah/reuse-vchan-write

  

  Isaiah Becker-Mayer

  authored
  787b67e

• small fixes from CR

  

  Isaiah Becker-Mayer

  committed
  6cd9ac2

• Merge branch 'master' into isaiah/reuse-vchan-write

  

  Isaiah Becker-Mayer

  authored
  997b7d6

• Merge branch 'isaiah/reuse-vchan-write' into isaiah/mock-drive-redirection

  

  Isaiah Becker-Mayer

  committed
  eb8ed1a

Commits on Apr 6, 2022

• A right click sends an ClientDeviceListAnnounce message and the rdp client parses the DeviceCreateRequest that's immediately sent back

  

  Isaiah Becker-Mayer

  committed
  54b53d0

Commits on Apr 8, 2022

• adds prototype logic for handling IRP_MJ_QUERY_INFORMATION and IRP_MJ_CLOSE

  

  Isaiah Becker-Mayer

  committed
  8f1ead3

Commits on Apr 11, 2022

• removes some un needed comments. the link to the documentation is enough in most cases, no need to neurotically add every bit of the documentation text to the code itself

  

  Isaiah Becker-Mayer

  committed
  9a88738

Commits on Apr 15, 2022

• Successfully mocks a drive for redirection

  

  Isaiah Becker-Mayer

  committed
  fb60ebb

Commits on Apr 19, 2022

• adding important todo

  

  Isaiah Becker-Mayer

  committed
  51f83e5

Commits on Apr 25, 2022

• removes unneeded pub decl

  

  Isaiah Becker-Mayer

  committed
  b4192a6

• refactors rdpdr into its own self-contained folder module

  

  Isaiah Becker-Mayer

  committed
  6cf694a

Commits on Apr 26, 2022

• moving scard into rdpdr

  

  Isaiah Becker-Mayer

  committed
  fa0d555

• allowing dead code

  

  Isaiah Becker-Mayer

  committed
  4b9c330

• stubs out request_file_info

  

  Isaiah Becker-Mayer

  committed
  66eb895

Commits on Apr 27, 2022

• fixes mismatched declaration

  

  Isaiah Becker-Mayer

  committed
  687b84c

• completes IRP_MJ_DEVICE_CONTROL

  

  Isaiah Becker-Mayer

  committed
  058530b

• adds a check for allow_directory_sharing so that we guarantee its functionality is disabled if that gets set in RBAC

  

  Isaiah Becker-Mayer

  committed
  1543585

• adds SharedDirectoryAnnounce and removes the right click hack from client.go

  

  Isaiah Becker-Mayer

  committed
  549eb02

Commits on Apr 28, 2022

• Adds SharedDirectoryAcknowledge tdp message, refactors rust-go interface to use the device id created by the client for the SharedDirectoryAnnounce to be used by rdp, rather than hardcoded DRIVE_DE…

  Show description for 8c5e2b1
  

  Isaiah Becker-Mayer

  committed
  8c5e2b1

• updates naming convention

  

  Isaiah Becker-Mayer

  committed
  de13b64

• Making sense of handle_client_id_confirm

  

  Isaiah Becker-Mayer

  committed
  8017ef2

• finishes out shared directory ack

  

  Isaiah Becker-Mayer

  committed
  1ce587f

Commits on Apr 29, 2022

• updates to new sd_acknowledge

  

  Isaiah Becker-Mayer

  committed
  66b5b00

Commits on Apr 30, 2022

• uses a struct for ack

  

  Isaiah Becker-Mayer

  committed
  de8e052

Commits on May 2, 2022

• roadblock at 'static lifetime error

  

  Isaiah Becker-Mayer

  committed
  0feae71

Commits on May 3, 2022

• refactors codebase to only contain shared directory announce and shared directory acknowledge

  

  Isaiah Becker-Mayer

  committed
  20d9aeb

• Merge branch 'master' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  ec900b8

• Merge branch 'master' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  e43694b

Commits on May 4, 2022

• fixes function name typo

  

  Isaiah Becker-Mayer

  committed
  95af26b

Commits on May 6, 2022

• checking in to go work on other stuff

  

  Isaiah Becker-Mayer

  committed
  2adf291

• rather than passing errors via C-strings, we pass them as integers which removes a major potential memory leak/error footgun

  

  Isaiah Becker-Mayer

  committed
  eec39f5

• Merge branch 'master' into isaiah/cgo-err-code

  

  Isaiah Becker-Mayer

  authored
  c43d688

Commits on May 7, 2022

• giving CGOErrCode explicit values

  

  Isaiah Becker-Mayer

  committed
  a56236f

• removing useless format

  

  Isaiah Becker-Mayer

  committed
  20efe3e

Commits on May 9, 2022

• adding feature flag

  

  Isaiah Becker-Mayer

  committed
  dac6c41

• adding #[allow(dead_code)]

  

  Isaiah Becker-Mayer

  committed
  6251502

• Merge branch 'master' into isaiah/cgo-err-code

  

  Isaiah Becker-Mayer

  authored
  2cb663d

• Merge branch 'isaiah/cgo-err-code' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  3615580

• Debugf

  

  Isaiah Becker-Mayer

  committed
  7fe5b95

• Merge branch 'master' into isaiah/cgo-err-code

  

  Isaiah Becker-Mayer

  authored
  9274c31

• Merge branch 'isaiah/cgo-err-code' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  7975209

• Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/stub-irp-mj-create

  

  Isaiah Becker-Mayer

  committed
  b0072f9

• removing mentions of code side

  

  Isaiah Becker-Mayer

  committed
  ce1c6c5

• Merge branch 'isaiah/cgo-err-code' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  1732e90

• Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/stub-irp-mj-create

  

  Isaiah Becker-Mayer

  committed
  6605005

• removing dangling CGO_OK

  

  Isaiah Becker-Mayer

  committed
  224db3a

• making a mod.rs

  

  Isaiah Becker-Mayer

  committed
  9ec0cba

• moving scard in rdpdr

  

  Isaiah Becker-Mayer

  committed
  ee34ddd

• moves constants into consts.rs

  

  Isaiah Becker-Mayer

  committed
  dbedfc8

• Adds go build flags for directory sharing and some basic scaffolding for handling them

  

  Isaiah Becker-Mayer

  committed
  df26b8f

• Merge branch 'isaiah/shared-directory-build-flag' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  e0bbfcf

• Merge branch 'master' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  eccab5a

• reverting e

  

  Isaiah Becker-Mayer

  committed
  51c956c

Commits on May 10, 2022

• Id to ID

  

  Isaiah Becker-Mayer

  committed
  8d532c8

• typo

  

  Isaiah Becker-Mayer

  committed
  750fe60

Commits on May 11, 2022

• proof of concept for calling the closures from golang. Checkpoing commit with tdp_sd_create_request, going to delete this on another branch

  

  Isaiah Becker-Mayer

  committed
  f4959ee

• trims rust back to bare minimum required for poc

  

  Isaiah Becker-Mayer

  committed
  e5d849e

• adds TypeSharedDirectoryAcknowledge, TypeSharedDirectoryInfoRequest, and TypeSharedDirectoryInfoResponse

  

  Isaiah Becker-Mayer

  committed
  f146e42

Commits on May 12, 2022

• Adds sharedDirectoryInfoRequest to go client

  

  Isaiah Becker-Mayer

  committed
  53cc341

• adds SharedDirectoryInfoResponse to go client

  

  Isaiah Becker-Mayer

  committed
  fe4bd3e

• Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/rdp-tdp-transl-arch

  

  Isaiah Becker-Mayer

  committed
  6bfc7a3

• CR

  

  Isaiah Becker-Mayer

  committed
  27d7c53

• fixes compiler errors

  

  Isaiah Becker-Mayer

  committed
  f00eeb6

Commits on May 14, 2022

• Adds the straightforward failure modes

  

  Isaiah Becker-Mayer

  committed
  0227339

• adds file_cache

  

  Isaiah Becker-Mayer

  committed
  cd4b5a2

• adds Shared Directory Create Request

  

  Isaiah Becker-Mayer

  committed
  9ebf970

Commits on May 15, 2022

• adds Shared Directory Delete Request

  

  Isaiah Becker-Mayer

  committed
  8d97123

• fills out the rest of IRP_MJ_CREATE

  

  Isaiah Becker-Mayer

  committed
  034f396

• adds plumbing for calling handle_tdp_sd_create_response and handle_tdp_sd_delete_response from go

  

  Isaiah Becker-Mayer

  committed
  b01c4ee

• adds logic for calling handle_tdp_sd_create_response and handle_tdp_sd_delete_response from go

  

  Isaiah Becker-Mayer

  committed
  d7950f6

• reverting mistaken Makefile change

  

  Isaiah Becker-Mayer

  committed
  1db2ff5

• Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create

  

  Isaiah Becker-Mayer

  committed
  e1ce4ce

Commits on May 17, 2022

• adds missing STATUS_SUCCESS messages

  

  Isaiah Becker-Mayer

  committed
  664a8e4

• adds logic for IRP_MJ_QUERY_INFORMATION

  

  Isaiah Becker-Mayer

  committed
  6ce109a

• adding dead_code tag

  

  Isaiah Becker-Mayer

  committed
  3dc58ad

• reverting Makefile

  

  Isaiah Becker-Mayer

  committed
  90350d1

• Adds handling of IRP_MJ_CLOSE

  

  Isaiah Becker-Mayer

  committed
  a71b390

Commits on May 18, 2022

• Merge branch 'master' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  authored
  c4371da

• refactored all available, now realizing that I should've branched off of isaiah/irp-mj-close. checking in here to merge that on the next commit, and then do the same refactor patter for irp-mj-close.

  

  Isaiah Becker-Mayer

  committed
  9e4db09

• Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor

  

  Isaiah Becker-Mayer

  committed
  511b1d2

• moves IRP_MJ_CLOSE handling into process_irp_close

  

  Isaiah Becker-Mayer

  committed
  02f3ec9

Commits on May 19, 2022

• fixing build bug and go lint errors

  

  Isaiah Becker-Mayer

  committed
  750e7ff

• merging branch isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  5bd7968

• Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create

  

  Isaiah Becker-Mayer

  committed
  15fb5c5

• reverting Makefile

  

  Isaiah Becker-Mayer

  committed
  efa9ac1

• Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information

  

  Isaiah Becker-Mayer

  committed
  23ddd4d

• Merge branch 'isaiah/irp-mj-query-information' into isaiah/irp-mj-close

  

  Isaiah Becker-Mayer

  committed
  67ee1b8

• Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor

  

  Isaiah Becker-Mayer

  committed
  8e0a0ed

• Adds CGOTdpErrCode. Go behaves oddly with enums being placed in structs, opting make them go type uint32. We're essentially just handling this manually with errCodeToTdpErrCode.

  

  Isaiah Becker-Mayer

  committed
  61d2509

• I decided there's no need to use errCodeToTdpErrCode at all. We can just use the normal enum types in typescript and Rust, and trust that the values are correct in Go

  

  Isaiah Becker-Mayer

  committed
  f6f7c69

• adding CGOFileType

  

  Isaiah Becker-Mayer

  committed
  8dc6616

• changed up the naming convention for these enums, since the primary reason for the previous convention with CGOErrCode is that we were using members directly in Go. But in this case, we don't touch…

  Show description for 57a826c
  

  Isaiah Becker-Mayer

  committed
  57a826c

• fixing rust linting problems

  

  Isaiah Becker-Mayer

  committed
  b449124

• Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/rdp-tdp-transl-arch

  

  Isaiah Becker-Mayer

  committed
  6b304ff

• fixing clippy errors

  

  Isaiah Becker-Mayer

  committed
  766c0ca

• Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create

  

  Isaiah Becker-Mayer

  committed
  93ba0bf

• Fixes linting errors

  

  Isaiah Becker-Mayer

  committed
  3c3db15

• Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information

  

  Isaiah Becker-Mayer

  committed
  570019a

• fixing lint errors and reverting Makefile

  

  Isaiah Becker-Mayer

  committed
  58cf5e2

• Merge branch 'isaiah/irp-mj-query-information' into isaiah/irp-mj-close

  

  Isaiah Becker-Mayer

  committed
  7155ef4

• fixing clippy errors

  

  Isaiah Becker-Mayer

  committed
  7e4986f

• Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor

  

  Isaiah Becker-Mayer

  committed
  cde94ea

• fixing clippy errors

  

  Isaiah Becker-Mayer

  committed
  bd86280

Commits on May 20, 2022

• fixing Makefile

  

  Isaiah Becker-Mayer

  committed
  1abfd00

Commits on May 23, 2022

• reverting mistaken e/webassets update

  

  Isaiah Becker-Mayer

  committed
  d296a51

• reverting mistaken Makefile change

  

  Isaiah Becker-Mayer

  committed
  75363f1

Commits on May 25, 2022

• Merge branch 'master' into isaiah/tdp-sd-announce-ack

  

  Isaiah Becker-Mayer

  committed
  332af85

Commits on May 27, 2022

• Update lib/srv/desktop/rdp/rdpclient/librdprs.h

  Show description for 416b8a0
  

  Isaiah Becker-Mayer

  and

  zmb3

  authored
  416b8a0

• Update lib/srv/desktop/rdp/rdpclient/src/lib.rs

  Show description for aff394c
  

  Isaiah Becker-Mayer

  and

  zmb3

  authored
  aff394c

• Code review

  

  Isaiah Becker-Mayer

  committed
  d773592

Commits on May 31, 2022

• refactoring handle_device_reply to clarify which part is for directory sharing vs which part is for smart card redirection

  

  Isaiah Becker-Mayer

  committed
  ded34fc

• changing try_from to as

  

  Isaiah Becker-Mayer

  committed
  7df9b4f

• adds doc comment for new_drive

  

  Isaiah Becker-Mayer

  committed
  901aa3d

• adding doc for write_client_device_list_announce

  

  Isaiah Becker-Mayer

  committed
  eade41e

• Removes CapabilityType::CAP_DRIVE_TYPE from the capability set if directory sharing is disabled (by RBAC)

  

  Isaiah Becker-Mayer

  committed
  9077167

• adds docstring to sharedDirectoryAcknowledge

  

  Isaiah Becker-Mayer

  committed
  88847b6

• Merge branch 'isaiah/tdp-sd-announce-ack' into isaiah/rdp-tdp-transl-arch

  

  Isaiah Becker-Mayer

  committed
  0bb389c

Commits on Jun 13, 2022

• Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create

  

  Isaiah Becker-Mayer

  committed
  c1ef663

• removes an unnecessary comment and adds a necessary one

  

  Isaiah Becker-Mayer

  committed
  4fbb4d7

Commits on Jun 14, 2022

• Adds docstrings to TDP types

  

  Isaiah Becker-Mayer

  committed
  791c98c

• Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information

  

  Isaiah Becker-Mayer

  committed
  13f898a

• code readability improvement

  

  Isaiah Becker-Mayer

  committed
  698bcd0

• adding tests for to_windows_time

  

  Isaiah Becker-Mayer

  committed
  9451f8c

• Merge branch 'master' into isaiah/rdp-tdp-transl-arch

  

  Isaiah Becker-Mayer

  committed
  cc177dc

Commits on Jun 15, 2022

• linting

  

  Isaiah Becker-Mayer

  committed
  09c0226

• Merge branch 'master' into isaiah/rdp-tdp-transl-arch

  

  Isaiah Becker-Mayer

  committed
  d74e4bf

• Merge branch 'master' into isaiah/rdp-tdp-transl-arch

  

  Isaiah Becker-Mayer

  authored
  070f46e

• Merge branch 'isaiah/rdp-tdp-transl-arch' into isaiah/complete-irp-mj-create

  

  Isaiah Becker-Mayer

  committed
  c4dc2d1

• Merge branch 'isaiah/complete-irp-mj-create' into isaiah/irp-mj-query-information

  

  Isaiah Becker-Mayer

  committed
  bf24ec3

• Merge branch 'isaiah/irp-mj-query-information' into isaiah/irp-mj-close

  

  Isaiah Becker-Mayer

  committed
  f9aa687

• improving code flow

  

  Isaiah Becker-Mayer

  committed
  b3cff62

• adds more clarifying comments

  

  Isaiah Becker-Mayer

  committed
  b64c746

• Merge branch 'isaiah/irp-mj-close' into isaiah/irp-mj-refactor

  

  Isaiah Becker-Mayer

  committed
  e5ad2d9

• style fixes and superfluous code removed

  

  Isaiah Becker-Mayer

  committed
  3f5cccb

• changes if-else to match

  

  Isaiah Becker-Mayer

  committed
  147b9d0

Commits on Jun 25, 2022

• Merge branch 'windows-desktop-directory-sharing' into isaiah/irp-mj-refactor

  

  Isaiah Becker-Mayer

  committed
  6d2af24