dronegen/mac.go: Sync Connect version with Teleport #13099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to re-run dronegen on #12257 if you merge this in. |
ravicious
force-pushed
the
ravicious/connect-build-improvements
branch
from
ddaec35
to
6cc92d9
Compare
ravicious
changed the title
ravicious
changed the title
|
I reverted the change which dynamically looks up which dir Teleport Connect is built under. At this point in the build script, At least now I know that if we ever decide to change the name of the dir, updating the build steps won't be as hard as I thought it'd be. |
zmb3
approved these changes
Jun 6, 2022
strideynet
approved these changes
Jun 6, 2022
ravicious
added a commit
to gravitational/webapps
that referenced
this pull request
Jun 8, 2022
We didn't end up using it, see gravitational/teleport#13099.
ravicious
added a commit
to gravitational/webapps
that referenced
this pull request
Jun 10, 2022
We didn't end up using it, see gravitational/teleport#13099.
ravicious
added a commit
to gravitational/webapps
that referenced
this pull request
Jun 13, 2022
* Remove get-teleport-connect-dir We didn't end up using it, see gravitational/teleport#13099. * Run build-term & package-term in Webapps-Build pipeline * Remove build script from package.json It seems like it's no longer used anywhere at this point.
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
* Remove get-teleport-connect-dir We didn't end up using it, see gravitational#13099. * Run build-term & package-term in Webapps-Build pipeline * Remove build script from package.json It seems like it's no longer used anywhere at this point.
hatched
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Remove get-teleport-connect-dir We didn't end up using it, see #13099. * Run build-term & package-term in Webapps-Build pipeline * Remove build script from package.json It seems like it's no longer used anywhere at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improvement to #12257.
This PR makes it so that instead of using the
versionfield frompackages/teleterm/package.json, electron-builder will use the version number passed through CLI flags. This will make sure that Connect always uses the same version number as other Teleport artifacts.Also, the Drone build number will be added as
BUILD_NUMBERso that it'll be visible in the final app (1337in the screenshot).The Drone run with recent changes: https://drone.platform.teleport.sh/gravitational/teleport/12533/12/1