Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenSSH Proxy Jump docs #13170
Add OpenSSH Proxy Jump docs #13170
Changes from 2 commits
f430f20
0e5018c
36553b1
5d6c3c2
d4bdafd
e8c1ee3
cebf01c
f8bed0a
2eecef3
26e7f78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This YAML snippet needs some introduction. I would add a paragraph that transitions from the last snippet. For example:
We could then delete the mention of the
tsh
configuration file location from above.Again, if this configuration only applies to the
-J
flag, I'm guessing we need some explicit instructions for the user to edit theirtsh config
-created configuration to include the-J
flag. Also, we should probably introduce the-J
flag outside of this guide, since it looks like it's intended for alltsh
commands, not just those involving legacy OpenSSH servers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently mention the
-J
flag in one other spot - https://goteleport.com/docs/ver/10.0/server-access/guides/tsh/#ssh-jump-hostAnd then there are there's the ssh man pages which are relevant as well:
Do you think we need to expand the tsh jump host section? If so, how will we fit in these docs to include the OpenSSH client integration with
tsh config
? Maybe that's where anOpenSSH Client guide
would come in?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use "host" instead of "node" when talking about servers that are running
openssh
but not Teleport. This way, there's no risk of confusion with Teleport Nodes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we are talking about connecting to Teleport Nodes with
ssh
and the openssh configuration file, though it can also be used to connect to openssh hosts. I'll update it to fit both cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually in this example these are only Teleport nodes. I am adding an example of connecting to an openSSH host though.