Backport of #10746 to v8 #13196
Merged
Backport of #10746 to v8 #13196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way was dronegen never backported to v8? |
github-actions
bot
requested review from
klizhentas,
logand22,
r0mant,
russjones,
tcsc,
wadells,
webvictim and
zmb3
|
@fheinecke It's possible that it wasn't, although I thought it was written before then... |
Dronegen was intentionally removed from v8 in fadcdaf #9464. If we fix the centos rpm publishing logic, it could be reintroduced. IMO this probably isn't worth the trouble, since we'll no longer support |
tcsc
approved these changes
Jun 9, 2022
wadells
approved these changes
Jun 9, 2022
| @@ -0,0 +1,75 @@ | |||
| --- | |||
There was a problem hiding this comment.
Same remark as #13197 (review), we probably don't need to backport the RFD itself.
zmb3
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10746 into v8. This adds the new APT build tool and APT repository.