Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update docs for passwordless, WebAuthn and U2F #13314

Merged
merged 31 commits into from
Jul 6, 2022

Conversation

codingllama
Copy link
Contributor

Add a batch of public documentation changes that cover:

  • Passwordless (new guide and various links)
  • WebAuthn updates in regards to U2F
  • U2F documentation removal (superseded by WebAuthn)
  • Updated config reference (teleport.yaml and equivalents)
  • Updated tsh reference

This should cover the bulk of the work under Passwordless (#9160) and U2F sunset (#10375).

#9160

@codingllama
Copy link
Contributor Author

Note to reviewers: feel free to review commit-by-commit.

Technically we want this for v10, but I'm happy to backport if we cut the branch before it; no code changes here after all.

@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch from d3da814 to ecae648 Compare June 8, 2022 20:48
@@ -686,11 +687,14 @@ registered devices using [`tsh mfa ls`](cli.mdx#tsh-mfa-ls).
$ tsh mfa rm <device-name>
```

### tsh environment variables
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this header was missing (without it the variables are all inside the "tsh mfa add" header).

@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch from ecae648 to 2bc51a2 Compare June 8, 2022 21:38
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well written. Nice work.

docs/pages/access-controls/guides/passwordless.mdx Outdated Show resolved Hide resolved
@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch from 2bc51a2 to e56ef0c Compare June 10, 2022 13:35
@codingllama
Copy link
Contributor Author

Updated and rebased, PTAL?

@codingllama
Copy link
Contributor Author

Friendly ping @ptgott @r0mant @xinding33 ?

docs/pages/access-controls/guides/passwordless.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/passwordless.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/passwordless.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/passwordless.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/passwordless.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/webauthn.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/webauthn.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/webauthn.mdx Outdated Show resolved Hide resolved
docs/pages/access-controls/guides/webauthn.mdx Outdated Show resolved Hide resolved
@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch 2 times, most recently from a128bd0 to 4004d23 Compare June 22, 2022 21:52
@codingllama
Copy link
Contributor Author

Thanks for the detailed review, Paul. Applied/fixed some of the "easier" comments, more to come later. I'll let you know when it's ready for another pass.

@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch from c716a8a to e74f665 Compare June 23, 2022 19:41
@codingllama
Copy link
Contributor Author

All comments addressed, PTAL. @ptgott

@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch 5 times, most recently from 9760755 to 0d74b77 Compare July 5, 2022 14:18
@codingllama
Copy link
Contributor Author

Friendly ping @ptgott ?

@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch from 0d74b77 to 0651a6a Compare July 6, 2022 18:01
@codingllama codingllama force-pushed the codingllama/pwdless-public-docs branch from f8f3d0c to 6fd8e1d Compare July 6, 2022 20:19
@codingllama codingllama merged commit 71e85c4 into master Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

@codingllama See the table below for backport results.

Branch Result
branch/v10 Failed

@codingllama codingllama deleted the codingllama/pwdless-public-docs branch July 6, 2022 20:35
@codingllama
Copy link
Contributor Author

branch/v10 | Failed

😭

@codingllama
Copy link
Contributor Author

Backport: #14163

codingllama added a commit that referenced this pull request Jul 6, 2022
Add a batch of public documentation changes that cover:

* Passwordless (new guide and various links)
* WebAuthn updates in regards to U2F
* U2F documentation removal (superseded by WebAuthn)
* Updated config reference (`teleport.yaml` and equivalents)
* Updated `tsh` reference

This should cover the bulk of the work under Passwordless (#9160) and
U2F sunset (#10375).

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
codingllama added a commit that referenced this pull request Jul 6, 2022
…4163)

Add/update docs for passwordless, WebAuthn and U2F (#13314)

Add a batch of public documentation changes that cover:

* Passwordless (new guide and various links)
* WebAuthn updates in regards to U2F
* U2F documentation removal (superseded by WebAuthn)
* Updated config reference (`teleport.yaml` and equivalents)
* Updated `tsh` reference

This should cover the bulk of the work under Passwordless (#9160) and
U2F sunset (#10375).

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
@webvictim webvictim mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants