[v9] Backport #12891

[xacrimon]

Backport of #12891. This was a bit of a messy backport with some surgery involved. Tests pass and it seems to work when tested with AD.

[zmb3]

I tried to run this and couldn't make a connection to the desktop.

Logs show:

[2022-06-13T14:48:26Z WARN  rustls::check] Received a ServerHelloDone handshake message while expecting [CertificateRequest]

I confirmed that connecting to the same desktop with master (4742327) and branch/v9 (197f06a) works fine.

@xacrimon @LKozlowski could you take a look?

[xacrimon]

@zmb3 Noting this for context, said log message is a bug in Rustls that is somehow spurious since it's valid to receive a ServerHelloDone before a CertificateRequest, see rustls/rustls#1012 for details. Do you see anything else in the logs that could be relevant?

[zmb3]

Interesting - I went back to this branch and tried again and now it is working, and I do not see this rustls message in the logs when it works.

Plus, based on the changes here, I wouldn't expect these to cause issues with rustls.

Is our rustls out of date by chance though? Maybe an update could help?

[xacrimon]

@zmb3 As expected this is a transient issue due to rustls. I went ahead and made a semver compatible update of all deps using cargo update. It did update rustls from 0.20.4 to 0.20.6 which fixes this according to patchnotes. Should be good to go now.

[xacrimon]

Does the unicode clipboard work too?

[zmb3]

@xacrimon Yep, works a charm.

[zmb3]

@xacrimon sorry, one more thing - since this was already merged to master, our Rust deps are probably out of sync. Would you mind opening a PR to master as well with the cargo update results?

[xacrimon]

Yep, @zmb3 could you approve this though?