[v8] Deflake TestX11Forward #13494
Merged
[v8] Deflake TestX11Forward #13494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails similarly to TestAgentForward, because the file-based session uploader runs in the background and is sometimes still writing to disk when the test goes to clean up temp directories. Since this test has nothing to do with the disk-based uploader or the audit log, we use a discard emitter and set the session recording mode to synchronous so there are no files on disk which need to be uploaded.
github-actions
bot
requested review from
alistanis,
greedy52,
Joerger,
nklaassen and
r0mant
Joerger
approved these changes
Jun 14, 2022
greedy52
approved these changes
Jun 15, 2022
alistanis
approved these changes
Jun 15, 2022
r0mant
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #13477 to branch/v8