Use make release-windows on Drone, make it similar to make release
#13532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Jun 15, 2022
codingllama
force-pushed
the
codingllama/windows-drone
branch
from
24b210f to
3d12f8f
Compare
Definitely! |
zmb3
approved these changes
Jun 15, 2022
codingllama
force-pushed
the
codingllama/windows-drone
branch
from
3d12f8f to
65495bd
Compare
@zmb3 I think not, at least I didn't find a link between this change and e/ yet. |
codingllama
added a commit
that referenced
this pull request
Jun 15, 2022
#13532) Switch from `make release-amd64` to make release-windows in Drone builds, making release builds similar to "regular" builds (that already use `make release-windows-unsigned`). Fixes current woes caused by FIDO2=yes in Windows release builds. (Note that ARCH is implied by the build.) * Use `make release-windows` on Drone, make it similar to `make release` * Update .drone.yaml
codingllama
added a commit
that referenced
this pull request
Jun 15, 2022
#13532) (#13540) Switch from `make release-amd64` to make release-windows in Drone builds, making release builds similar to "regular" builds (that already use `make release-windows-unsigned`). Fixes current woes caused by FIDO2=yes in Windows release builds. (Note that ARCH is implied by the build.) * Use `make release-windows` on Drone, make it similar to `make release` * Update .drone.yaml
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
make release-amd64tomake release-windowsin Drone builds, making release builds similar to "regular" builds (that already usemake release-windows-unsigned).Fixes current woes caused by FIDO2=yes in Windows release builds. (Note that ARCH is implied by the build.)