Repoint doctest build #13717
Merged
Repoint doctest build #13717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
approved these changes
Jun 22, 2022
|
Once we merge this, we'll need to merge this branch as well to prevent |
Best thing is probably to add those commits here, otherwise this will never pass CI |
In gravitational/docs, relative links in partials are revaluated relative to the filepath of the partial, not to the page that includes that partial. In other words, a link in the same partial will be resolved differently depending on the filepath of the page that includes it. To accommdate this link resolution method, this change edits relative links within the CHANGELOG to be relative to that file, rather than to docs/pages/changelog.mdx, which includes it.
…' into tcsc/port-doctests-to-docs-image
r0mant
approved these changes
Jun 23, 2022
This was referenced Jun 23, 2022
ptgott
added a commit
that referenced
this pull request
Jul 5, 2022
* Repoint docttest build * relabel image * Fix CHANGELOG links for new resolution method In gravitational/docs, relative links in partials are revaluated relative to the filepath of the partial, not to the page that includes that partial. In other words, a link in the same partial will be resolved differently depending on the filepath of the page that includes it. To accommdate this link resolution method, this change edits relative links within the CHANGELOG to be relative to that file, rather than to docs/pages/changelog.mdx, which includes it.
ptgott
added a commit
that referenced
this pull request
Jul 5, 2022
* Repoint docttest build * relabel image * Fix CHANGELOG links for new resolution method In gravitational/docs, relative links in partials are revaluated relative to the filepath of the partial, not to the page that includes that partial. In other words, a link in the same partial will be resolved differently depending on the filepath of the page that includes it. To accommdate this link resolution method, this change edits relative links within the CHANGELOG to be relative to that file, rather than to docs/pages/changelog.mdx, which includes it.
ptgott
added a commit
that referenced
this pull request
Jul 7, 2022
* Repoint docttest build * relabel image * Fix CHANGELOG links for new resolution method In gravitational/docs, relative links in partials are revaluated relative to the filepath of the partial, not to the page that includes that partial. In other words, a link in the same partial will be resolved differently depending on the filepath of the page that includes it. To accommdate this link resolution method, this change edits relative links within the CHANGELOG to be relative to that file, rather than to docs/pages/changelog.mdx, which includes it.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the image used to run the
doc-testsCI build and pulls in changes from #13774 to fix compatibility issues with the new image.See-Also: #13457
Co-Authored-By: @ptgott