[v10] Pass proxy address to PromptMFAChallenge calls (#13772) #13855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tsh
ryanclark
approved these changes
Jun 24, 2022
zmb3
approved these changes
Jun 24, 2022
codingllama
force-pushed
the
codingllama/v10-proxy-prompt-mfa
branch
2 times, most recently
from
e0775ad to
3b34796
Compare
Reinstates some logic that was removed on #12475 and changes `optsOverride` to a function, so there is less ambiguity in dealing with booleans / default values. * Pass proxy address to PromptMFAChallenge calls * Add coverage for TeleportClient.PromptMFAChallenge
codingllama
force-pushed
the
codingllama/v10-proxy-prompt-mfa
branch
from
3b34796 to
e9b47ef
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstates some logic that was removed on #12475 and changes
optsOverrideto afunction, so there is less ambiguity in dealing with booleans / default values.