[v10] Teleport Connect: Add SetGatewayTargetSubresourceName RPC #13884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cliCommand.Env is empty, the returned command has an empty space at the front.
RPCs used to be grouped by action (List/Add/Remove) but I think the longer the list of RPCs gets, the less maintainable this is and it'd be better to group them by resources instead.
Since we want to be able to freely specify the db name after the gateway creation, let's not pass the db name when creating the gateway to show the intent more clearly.
…ceName * cliCommandProvider has been moved from Cluster to Gateway. * Gateway has been modified so that it accepts cliCommandProvider during its creation. * Later it can call cliCommandProvider to get the CLI command when needed. * Setting the CLI command is no longer done outside of Gateway.
This removes the need for SetTargetSubresourceName method on Gateway.
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
marcoandredinis
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Any reason for not cherry picking just the merge commit?
a7760a4
|
That's what I'd usually do when backporting PRs manually but it seems that the bot has a different way of doing that. That's also probably why it needs us to not automatically remove the branches after merging. By bot I mean tagging the PR with |
rosstimothy
approved these changes
Jun 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #13476 to branch/v10