Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use hostname to find an existing server #1412

Merged
merged 2 commits into from
Oct 17, 2017
Merged

use hostname to find an existing server #1412

merged 2 commits into from
Oct 17, 2017
+47 −25

Conversation

alex-kovoy
Copy link
Contributor

closes #1410

@alex-kovoy alex-kovoy changed the title user hostname to find an existing server use hostname to find an existing server Oct 17, 2017
kontsevoy
kontsevoy requested changes Oct 17, 2017
View reviewed changes
lib/web/terminal.go Outdated
// check if server exists by comparing its UUID or hostname
for i := range existingServers {
node := existingServers[i]
if node.GetName() == value || node.GetHostname() == value {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but lunA == Luna

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@kontsevoy kontsevoy merged commit 07eebbc into master Oct 17, 2017
@alex-kovoy alex-kovoy deleted the alexey/unlisted/ssh branch October 17, 2017 01:09
hatched pushed a commit that referenced this pull request Dec 20, 2022
@kimlisa
[Discover] Database Tweaks and Add ons (#1412)
a37ccab 
- Adds db access flags
- Adds missing permission check when users 
  are at create db step
- Add `sign/db` endpoint
- Add new db resource hostname field 
- Allow PingTeleportContext to take in an alternate search term
- Adds expected json fields for db connection tester
hatched pushed a commit that referenced this pull request Jan 30, 2023
@kimlisa @ryanclark
[v11] Discover: Implement Day 1 Database Postgres Flow (#1487)
f6912cd 
* Refactor DownloadScript Screens (#1367)
* Tentatively implement Create Database screen (#1372)
* Refactor TestConnection Screens (#1375)
* Database Tweaks and Add ons (#1412)
* Implement mutual TLS screen (#1418)
* Add all db options to db selector (#1441)
* Tweaks based on design review and regression fixes (#1433)
* Implement the IAM policy screen (#1459)
* Add database service checker and various db tweaks (#1481)
* Temp remove db service checker until bug is fixed (#1495)

Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russjones russjones russjones approved these changes

@kontsevoy kontsevoy kontsevoy approved these changes

@klizhentas klizhentas klizhentas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH login via web UI does not work
4 participants
@alex-kovoy @klizhentas @kontsevoy @russjones