Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy peering message size buckets #14158

Merged
merged 12 commits into from
Jul 8, 2022
2 changes: 2 additions & 0 deletions lib/proxy/clientmetrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ func newClientMetrics() (*clientMetrics, error) {
Subsystem: "client",
Name: "message_sent_size",
Help: "Size of messages sent by the client.",
Buckets: messageByteBuckets,
},
[]string{"service", "handler"},
),
Expand All @@ -110,6 +111,7 @@ func newClientMetrics() (*clientMetrics, error) {
Subsystem: "client",
Name: "message_received_size",
Help: "Size of messages received by the client.",
Buckets: messageByteBuckets,
},
[]string{"service", "handler"},
),
Expand Down
3 changes: 3 additions & 0 deletions lib/proxy/reporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ import (
"github.com/prometheus/client_golang/prometheus"
)

// messageByteBuckets creates buckets ranging from 32-65536 bytes.
var messageByteBuckets = prometheus.ExponentialBuckets(32, 2, 12)

type metrics interface {
getConnectionGauge() *prometheus.GaugeVec
getRPCGauge() *prometheus.GaugeVec
Expand Down
2 changes: 2 additions & 0 deletions lib/proxy/servermetrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func newServerMetrics() (*serverMetrics, error) {
Subsystem: "server",
Name: "message_sent_size",
Help: "Size of messages sent by the server.",
Buckets: messageByteBuckets,
},
[]string{"service", "handler"},
),
Expand All @@ -90,6 +91,7 @@ func newServerMetrics() (*serverMetrics, error) {
Subsystem: "server",
Name: "message_received_size",
Help: "Size of messages received by the server.",
Buckets: messageByteBuckets,
},
[]string{"service", "handler"},
),
Expand Down