[v10] Make it possible to test gateway opening/closing in Connect #14183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open() and Close() used to not return any error and Open() used to start the gateway in a goroutine, making it rather hard to write tests for it. This commit makes it so that Open() and Close() return errors and Open() blocks. Adjustments have been made to other places in lib/teleterm to account for that missing goroutine and returned errors.
While writing tests for the gateways, I was relying heavily on tests for the local proxy. I noticed that it starts the server but doesn't close it so I added an appropriate call to the cleanup function.
espadolini
approved these changes
Jul 8, 2022
espadolini
approved these changes
Jul 8, 2022
ibeckermayer
approved these changes
Jul 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #14135 to branch/v10
This is not a huge change, but I want to wait for the initial v10 release before merging this.