[branch/v7] Remove refetching from resourceWatcher (#14262) #14307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resourceWatcher is meant to be a long lived way for a component to receive events about a particular resource from an upstream cache. However, there was a refetching mechanism that would cause a healthy and subscribed watcher to be closed, the resourceWatcher to fetch all the resource types it is watching from the upstream cache and to create a new watcher **every 10 minutes**. This causes unneeded load on the upstream cache and also eats up network bandwidth. This removes the refetching behavior entirely to ensure watchers aren't unnecessarily closed. The change should be transparent to users of the resourceWatcher, but should noticeably reduce both the number of init events being emitted through out a cluster and the number of cache reads. Fixes #14234 (cherry picked from commit dea633f) # Conflicts: # lib/services/watcher.go
espadolini
approved these changes
Jul 11, 2022
zmb3
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertobranch/v7:Questions ?
Please refer to the Backport tool documentation