-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] backports for 13630 14267 14959 15289 15364 15743 (directory sharing) #15770
Merged
ibeckermayer
merged 9 commits into
branch/v9
from
isaiah/backport-13630-14267-14959-15289-15364-branch/v9
Sep 7, 2022
Merged
[v9] backports for 13630 14267 14959 15289 15364 15743 (directory sharing) #15770
ibeckermayer
merged 9 commits into
branch/v9
from
isaiah/backport-13630-14267-14959-15289-15364-branch/v9
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `IRP_MJ_CREATE` (#12665) * `IRP_MJ_QUERY_INFORMATION` (#12717) * `IRP_MJ_CLOSE` (#12729) * Refactor rdpdr client (#12750) * Adding logic for `FILE_SUPERSEDE` (#12829) * Improve `process_irp_create` (#12830) * adds return statements that got lost in a merge * `IRP_MJ_DIRECTORY_CONTROL` (#12870) * `FileFullDirectoryInformation` (#12908) * Improve `ClientDriveQueryDirectoryResponse.encode()` (#12912) * `IRP_MJ_QUERY_VOLUME_INFORMATION` (#13071) * Fix Shared Directory Request handling when feature is disabled (#13439) * IRP_MJ_READ, IRP_MJ_WRITE, and IRP_MJ_SET_INFORMATION (#13995) * Adds constants for sizing calculations (#14051) Co-authored-by: Łukasz Kozłowski <lukasz.kozlowski@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@ibeckermayer - this PR is large and will require admin approval to merge. Consider breaking it up into a series smaller changes. |
ibeckermayer
changed the title
[v9] backports for 13630 14267 14959 15289 15364 (directory sharing)
[v9] backports for 13630 14267 14959 15289 15364 15743 (directory sharing)
Aug 26, 2022
zmb3
approved these changes
Sep 6, 2022
rand = { version = "0.8.5", features = ["getrandom"] } | ||
rand_chacha = "0.3.1" | ||
rsa = "0.6.1" | ||
rdp-rs = { git = "https://github.com/gravitational/rdp-rs", rev = "6075679e7c9bd8e3c2136a87f097d05c7db3235f" } | ||
rdp-rs = { git = "https://github.com/gravitational/rdp-rs", rev = "82bcc2d971a336f1550968c9aa617adb03deb2f1" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this to 888b15477d9aaceb83b2afcc73de040a07781d28 while we're here?
jakule
approved these changes
Sep 7, 2022
zmb3
deleted the
isaiah/backport-13630-14267-14959-15289-15364-branch/v9
branch
September 9, 2022 18:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #13630 #14267 #14959 #15289 #15364 #15743 to branch/v9
Note that this feature won't be turned on for v9. This is part of our "kitchen sink" approach to backports for this feature as discussed originally in #14012