[v8] Refactor Drone Pipelines to use AWS role assumption #17260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
fheinecke,
justinas,
r0mant and
reedloden
Previously it was in a different place in the .drone.yml on v8 than in v9+. This meant any changes to the pipeline would result in merge conflicts. After this change, the order is consistent with more recent branches that have dronegen.
These are reversed in master/v11 (ecr first, and then quay) and having the order consistent across branches will make future ports easier.
Previously, "${ARTIFACT_PATH}" was interpreted as Drone variable
subsitution, resulting in "rm -rf ${ARTIFACT_PATH}/*" becoming
"rm -rf /*", which deleted credentials on the filesystem.
This is follow up to #17201, that fixes the buildbox pipeline error seen here: An error occurred (AccessDeniedException) when calling the GetAuthorizationToken operation: User: arn:aws:iam::146628656107:user/teleport_build_user_read_only is not authorized to perform: ecr-public:GetAuthorizationToken on resource: * because no identity-based policy allows the ecr-public:GetAuthorizationToken action
This gives un-dronegen'ed pipelines the same syntax as dronegen'd ones, which is nice for consistency.
wadells
force-pushed
the
walt/v8-role-assumption
branch
2 times, most recently
from
e3791b0 to
dc4dc8b
Compare
All other roles environment variables end in AWS_ROLE, and consistency is our friend here.
This is a special one-off pipeline for v8
wadells
force-pushed
the
walt/v8-role-assumption
branch
from
e4490f4 to
1399ea4
Compare
This was referenced Oct 13, 2022
|
@wadells - this PR is large and will require admin approval to merge. Consider breaking it up into a series smaller changes. |
r0mant
approved these changes
Oct 13, 2022
reedloden
approved these changes
Oct 13, 2022
|
Tag and promte are clean. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #17201
Backports #17260
Backports #17334
Backports #17274
Backports #17314
Backports #17406
Contributes to https://github.com/gravitational/SecOps/issues/213
Porting drone changes to v8 is messy, due to the lack of dronegen and subsequent drift between branches.
Changes include:
clean-up-previous-buildpipeline was also mislocated, so I moved it before applying my changes (9946cac)Testing Done
Tag: https://drone.platform.teleport.sh/gravitational/teleport/16475
Promote: https://drone.platform.teleport.sh/gravitational/teleport/16483