Allow dev build promotes to proceed in deb/rpm pipelines #17340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps test a couple more changes from this pipeline when cutting a dev build. Particularly, we saw the download and role assumption steps fail in #17334, and this change would have allowed us to catch that error during testing.
Yes, with some additional work and testing. Essentially the |
fheinecke
approved these changes
Oct 12, 2022
r0mant
approved these changes
Oct 12, 2022
|
This work will continue forward in #17638 |
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps test a couple more changes from this pipeline when cutting a dev build. Particularly, we saw the download and role assumption steps fail in #17334, and this change would have allowed me to catch that error during testing.
@fheinecke: Do you see any way we could move the local yum repo package and sign before the cutoff, and only have the s3 upload be skipped? I took a look, but I wasn't familiar enough with the codepaths to feel confident making this more aggressive change.
Testing
I included the fixes from #17334 and I am running a complete dev build
tag: https://drone.platform.teleport.sh/gravitational/teleport/16393
promote: https://drone.platform.teleport.sh/gravitational/teleport/16444
Looks like there is still a credentials issue -- so please do not merge yet.