[v11] Improve trusted cluster observability #18609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves `UpdateTrustedCluster` logging from debug to info so default logging level includes when admin operations are performed to establish or remove trust. Alters `remoteSite` such that it logs in the same manner as `localSite` Cherry-picks some of the availability changes made in #18050 to ensure that agents spawned for trusted clusters are more robust to connection issues.
The metric wasn't properly updated when remote sites went offline of when remote cluster resources were removed. Any change to the remoteSite state or the remoteCluster resource are now accurately reflected in the metric.
The metric `trust_clusters` existed and was exported, but was never used anywhere. Now when the `RemoteClusterTunnelManager` starts and stops agent pools it will create and delete a counter for the cluster. Within the `AgentPool` the metric is set to the number of connected proxies within `updateConnectedProxies`.
Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
github-actions
bot
requested review from
alexfornuto,
nklaassen and
xacrimon
alexfornuto
approved these changes
Nov 18, 2022
nklaassen
approved these changes
Nov 18, 2022
zmb3
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #18484 to branch/v11