[v10] fix aws rds discovery invalid engine filter #18618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add helper func to check for AWS unrecognized engine error * Retry RDS queries with individual filters if engine name is unrecognized * godoc * pass engine names instead of filters, to make retry logic simpler * Update mocks to check/apply RDS engine filters * Update watcher tests * Add watcher test for unrecognized RDS engines * Update lib/srv/db/cloud/mocks.go Co-authored-by: Marek Smoliński <marek@goteleport.com> Co-authored-by: Marek Smoliński <marek@goteleport.com>
github-actions
bot
added
backport
database-access
greedy52
approved these changes
Nov 19, 2022
smallinsky
approved these changes
Nov 21, 2022
…invalid-engine-filter
…invalid-engine-filter
…invalid-engine-filter
…invalid-engine-filter
…invalid-engine-filter
…invalid-engine-filter
…invalid-engine-filter
…invalid-engine-filter
|
@zmb3 summary of flaky tests from the last 6 merge attempts:
🥲 |
|
@GavinFrazar would you mind confirming that we have an issue to track each of those? |
Removing duplicates, we have issues tracking all of them:
edit: I'll link logs in each issue |
This was referenced Dec 30, 2022
GavinFrazar
deleted the
gavinfrazar/v10-fix-aws-rds-discovery-invalid-engine-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #18328 to v10