Allow creating certificate authorities #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating certificate authorities is necessary during migration/recovery procedures.
|
@russjones @r0mant please review |
russjones
reviewed
Jun 8, 2018
| if err != nil { | ||
| return trace.Wrap(err) | ||
| } | ||
| if err := client.UpsertCertAuthority(certAuthority); err != nil { |
There was a problem hiding this comment.
Since this does a upsert and not create it's a pretty serious operation with which you can accidentally take down your entire cluster. We should probably prompt the user with something like before continuing.
Warning: Updating your certificate authorities can potentially put your
cluster in a unrecoverable state. Make sure you backup all Teleport state
and export your existing certificate authorities before you continue.
Are you sure you want to proceed?
There was a problem hiding this comment.
we don't have this flow anywhere, so I would let them do this on their own risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating certificate authorities is necessary during
migration/recovery procedures.