Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix twoClustersTunnel flakiness #26233

Conversation

tobiaszheller
Copy link
Contributor

@tobiaszheller tobiaszheller commented May 15, 2023

This PR fixes: #26225.

Before stopping auth, we make sure that 2nd event is received.

This test was flaky before but I believe it gotten worse after explicitly closing log on process stop (

teleport/lib/auth/auth.go

Lines 1191 to 1195 in e9d397e

if a.Services.AuditLogSessionStreamer != nil {
if err := a.Services.AuditLogSessionStreamer.Close(); err != nil {
errs = append(errs, err)
}
}
).

Node is using async emitter and if we stop auth immediately after sending exec, there is high chance that it won't be there. Adding explicit close on events log, cause it to fail more often because it's closed earlier.

@github-actions github-actions bot requested review from lxea and ryanclark May 15, 2023 14:06
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Merged via the queue into master with commit 57379c3 May 15, 2023
@tobiaszheller tobiaszheller deleted the tobiaszheller/fix-twoClustersTunnel-flaky-with-check-before-stop branch May 15, 2023 16:35
@public-teleport-github-review-bot

@tobiaszheller See the table below for backport results.

Branch Result
branch/v11 Create PR
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestIntegrations/TwoClustersTunnel/node flakiness
4 participants