Rotate certificate upon valid principals change. #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
force-pushed
the
rjones/refix-rotate
branch
from
4fefdf2
to
3b1156d
Compare
klizhentas
reviewed
Jun 28, 2019
Ignore 0.0.0.0 when checking if certificate needs to be rotated.
russjones
force-pushed
the
rjones/refix-rotate
branch
from
3b1156d
to
39464aa
Compare
klizhentas
reviewed
Jun 28, 2019
| // updated, the list of principals (SSH) or DNS names (TLS) on the | ||
| // certificate need to be updated. | ||
| if len(additionalPrincipals) != 0 && !conn.ServerIdentity.HasPrincipals(principalsToCheck) { | ||
| principalsChanged = true |
There was a problem hiding this comment.
if all you care about is that the certificates have changed, you can return here, and avoid the extra variable?
There was a problem hiding this comment.
It's for logging purposes, so we can debug what changed (was it SSH or TLS or both).
klizhentas
reviewed
Jun 28, 2019
| additionalPrincipals, conn.ServerIdentity.Cert.ValidPrincipals) | ||
| } | ||
| if len(dnsNames) != 0 && !conn.ServerIdentity.HasDNSNames(dnsNames) { | ||
| dnsNamesChanged = true |
klizhentas
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore 0.0.0.0 when checking if certificate needs to be rotated.